[OpenAL] Fix sourceSeek crash on stopped sources#26770
Open
uniformization wants to merge 3 commits intoemscripten-core:mainfrom
Open
[OpenAL] Fix sourceSeek crash on stopped sources#26770uniformization wants to merge 3 commits intoemscripten-core:mainfrom
uniformization wants to merge 3 commits intoemscripten-core:mainfrom
Conversation
sbc100
changed the title
sbc100
reviewed
Apr 24, 2026
Collaborator
sbc100
left a comment
sbc100
left a comment
There was a problem hiding this comment.
Could you maybe modify one of the existing tests in test_browser.py or test_inerative.py to cover this?
Author
@sbc100 I have added a test to |
sbc100
reviewed
Apr 25, 2026
| assert(state == AL_STOPPED); | ||
| alSourcef(source, AL_SEC_OFFSET, 0.5f); | ||
| alGetSourcei(source, AL_SOURCE_STATE, &state); | ||
| assert(state == AL_STOPPED); |
Collaborator
There was a problem hiding this comment.
Can you confirm this new test fails without this patch?
Author
There was a problem hiding this comment.
Let me know if the fix for this is good enough or if there's a better way of going about it. When an error is thrown from a function that was called with emscripten_async_call, it won't fail the test. (Line 306)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If you tried to use
AL_SEC_OFFSETon a stopped audio source, sourceSeek would throw aTypeErrorbecauseaudioBufwould be undefined.